feat(helm-chart): Allow configuration of ipFamilyPolicy

[dongjiang1989]

…n info

Description

1. update chart version and appVersion
2. support dualstack
3. update values.schema.json file

Fixes #

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Welcome @dongjiang1989!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dongjiang1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevehipwell]

Thanks for the PR @dongjiang1989, I've added some suggestions for how this should be implemented.

Could you also please undo the change to Chart.yaml and add an entry to the CHANGELOG.

[dongjiang1989]

Thanks for the PR @dongjiang1989, I've added some suggestions for how this should be implemented.

Could you also please undo the change to Chart.yaml and add an entry to the CHANGELOG.

Thanks for your review.
All done. Please re-check @stevehipwell

[stevehipwell]

The implementation here looks good. It's great to see the schema get updated but I'm slightly cautious over the fact that it needs validating.

/ok-to-test
/label tide/merge-method-squash

[stevehipwell]

@dongjiang1989 you need to run the helm-docs command locally.

[dongjiang1989]

@dongjiang1989 you need to run the helm-docs command locally.

Thanks for your review. Done.

[stevehipwell]

I've just taken a closer look at the schema and it doesn't look correct, types shouldn't be set to null. Could you change this PR to only add the schema for service?

[dongjiang1989]

I've just taken a closer look at the schema and it doesn't look correct, types shouldn't be set to null. Could you change this PR to only add the schema for service?

Thanks for your review. Just add the schema for service done.

[stevehipwell]

@dongjiang1989 could you fix the JSON schema formatting back to a 2 space indent with an EOF so only the change you made is showing?

[dongjiang1989]

@dongjiang1989 could you fix the JSON schema formatting back to a 2 space indent with an EOF so only the change you made is showing?

It was my mistake. Fixed

[stevehipwell]

Thanks for the quick response @dongjiang1989. You have still still stipped the EOF from values.yaml, could you put this back so we can get this tested for approval?

[dongjiang1989]

Thanks for the quick response @dongjiang1989. You have still still stipped the EOF from values.yaml, could you put this back so we can get this tested for approval?

Fixed in values.schema.json

[stevehipwell]

/approve

@mloiseleur do you want to LGTM this?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [stevehipwell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mloiseleur]

@stevehipwell let me have a look

[mloiseleur]

I have a little suggestion on the changelog, to be consistent the other lines of this changelog.

[mloiseleur]

/lgtm