Added TTL annotation check for azure records. #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/S
|
Thanks for the PR! Does it make sense to add a test for this? |
|
yes, this definitely needs a test @stromming please add it |
|
Running into problems while writing tests; provider.Records() creates an endpoint slice which ignores the TTL of the records (see e.g. external-dns/provider/azure.go on row 134). This is true for at least google and azure providers. Is this intended behaviour? If not I'll add fix to this PR Edit: Nevermind, will mimic behaviour from AWS provider. |
k8s-ci-robot
added
cncf-cla: yes
|
LGTM 👍 @peterhuene @TsuyoshiUshio What do you think? |
|
LGTM 👍 Thanks for the work, @stromming! |
grimmy
pushed a commit
to grimmy/external-dns
that referenced
this pull request
Apr 10, 2018
Added TTL annotation check for azure records.
lou-lan
pushed a commit
to lou-lan/external-dns
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.