Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add paris region #452

Merged
merged 2 commits into from
Jan 30, 2018
Merged

add paris region #452

merged 2 commits into from
Jan 30, 2018

Conversation

zparnold
Copy link
Contributor

Addresses #447 by adding the new AWS Paris region to the list of canonicalHostedZones.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2018
@mikkeloscar
Copy link
Contributor

👍

@hjacobs
Copy link
Contributor

hjacobs commented Jan 30, 2018

@hjacobs hjacobs merged commit bf93fd8 into kubernetes-sigs:master Jan 30, 2018
@zparnold zparnold deleted the add-paris-region branch January 30, 2018 14:15
@ideahitme
Copy link

ideahitme commented Feb 5, 2018

probably have to change the implementation to dynamically update the list, there is really no guarantee the list of IDs will never change 😶

grimmy pushed a commit to grimmy/external-dns that referenced this pull request Apr 10, 2018
* add paris region

* adds test
lou-lan pushed a commit to lou-lan/external-dns that referenced this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants