chore(chart): Released chart for v0.14.2 #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
chart-v0.14.2
branch
from
620adc5
to
aef83b9
Compare
|
CC @Raffo |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mloiseleur
reviewed
Jun 10, 2024
| @@ -17,7 +17,7 @@ spec: | |||
| {{- include "external-dns.selectorLabels" . | nindent 6 }} | |||
| strategy: | |||
| {{- toYaml .Values.deploymentStrategy | nindent 4 }} | |||
| {{- if or (kindIs "float64" .Values.revisionHistoryLimit) (kindIs "int64" .Values.revisionHistoryLimit) }} | |||
| {{- if not (has (quote .Values.revisionHistoryLimit) (list "" (quote ""))) }} | |||
There was a problem hiding this comment.
It works according to my test, but I have question.
Would it make sense to write something simpler like if (not (empty .Values.revisionHistoryLimit)) or am I missing something ?
There was a problem hiding this comment.
Unfortunately empty evaluates 0 to true so doesn't work for numeric values where 0 is a valid value.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR releases the Helm chart for
v0.14.2.Fixes #4482
Checklist