digitalocean: add API rate limit

[tja]

Description

This change adds a new command line parameter, --digitalocean-api-rate-limit, which allows to throttle calls to the DigitalOcean API. The DO API has a rate limit of 250 requests per minute, which is consistently hit when managing 100+ (sub-) domains.

Fixes #4572

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tja / name: Dr. Thomas Jansen (ab6194b)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @tja!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tja. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tja]

Hi @mloiseleur and @szuecs, would you mind giving me an estimate when to expect the review. Thanks in advance!

[mloiseleur]

Hi @tja,

FYI, we are currently moving providers out of tree, using webhook. See #4347
Infoblox provider has already moved, see #4516

[tja]

@mloiseleur, that's actually pretty cool! I'm unsure what that means for my PR, though. Does that mean it's better to wait or would integrating it before the move would make more sense to you?

[mloiseleur]

@tja It means you can either:

1. Submit a PR to provide an this Rate Limit parameters for all providers (not only Digital Ocean)
2. Create a webhook provider for Digital Ocean based from current in-tree code and add this feature to it