Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DigitalOcean creates entries with host in them twice #459

Merged
merged 5 commits into from
Feb 21, 2018
Merged

DigitalOcean creates entries with host in them twice #459

merged 5 commits into from
Feb 21, 2018

Conversation

njuettner
Copy link
Member

Fixes issue #458

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2018
@Noah-Huppert
Copy link

Thanks!

@ideahitme
Copy link

👍

@hjacobs
Copy link
Contributor

hjacobs commented Feb 9, 2018

@njuettner shouldn't we have a test for this to reproduce the bug and make sure the fix is permanent?

@ideahitme
Copy link

This is not a bug, just a weirdness in how DO API works I think, this might change any moment and should be covered by integration test (which we don't have :( )

@linki
Copy link
Member

linki commented Feb 12, 2018

@ideahitme Right, but I would also expect this to fail at least some tests.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2018
@linki linki added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2018
@linki linki merged commit f5b0d93 into master Feb 21, 2018
@linki linki deleted the bug/double-domain branch February 21, 2018 14:53
@linki
Copy link
Member

linki commented Feb 21, 2018

Thanks @njuettner

@Noah-Huppert Noah-Huppert mentioned this pull request Mar 29, 2018
Merged
grimmy pushed a commit to grimmy/external-dns that referenced this pull request Apr 10, 2018
@njuettner @linki
DigitalOcean creates entries with host in them twice (kubernetes-sigs…
cb29861 
…#459)

* DigitalOcean creates entries with host in them twice

* Unit test

* DigitalOcean creates entries with host in them twice (kubernetes-sigs#459)

* docs: cleanup changelog a little
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@linki linki

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@njuettner @Noah-Huppert @ideahitme @hjacobs @linki @k8s-ci-robot