Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc2136: merge Endpoints with same name/type into single Endpoint #4613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rfc2136: merge Endpoints with same name/type into single Endpoint #4613

wants to merge 1 commit into from

Conversation

bogdando
Copy link

@bogdando bogdando commented Jul 15, 2024 •
edited

Description

Rebased and reopened no longer maintained #1678
Related #1596

Map multiple DNS records with the same name/type into the external-dns which models such records as a single Endpoint with multiple entries in the Targets attribute.

Solution: Generalize the solution introduced to the DigitalOcean provider by #1595 by refactoring the mergeEndpointsByNameType function into the endpoint module. Then use that function in the RFC2136 provider.

Fixes #1596

Checklist

  • Unit tests updated
  • End user documentation updated
  • Tested with RFC2136 provider in a real deployment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @bogdando!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bogdando. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2024
@tdyas @bogdando
rfc2136: merge Endpoints with same name/type into single Endpoint
8cba8a0 
map multiple DNS records with the same name/type into the
external-dns which models such records as a single Endpoint with
multiple entries in the Targets attribute.

Solution: Generalize the solution introduced to the DigitalOcean
provider by kubernetes-sigs#1595 by refactoring the mergeEndpointsByNameType function
into the endpoint module. Then use that function in the RFC2136
provider.

Authored-by: Tom Dyas <tom.dyas@gmail.com>
Signed-off-by: Bogdan Dobrelya <bogdando@yahoo.com>
@bogdando
Copy link
Author

bogdando commented Jul 15, 2024 •
edited

I checked that this works for rfc2136 provider with endpoints list of a ~700 records, but all targets have a length of 1. It works without problems, or regressions. I don't have ideas how to make an artificial scenario with target len > 1. I hope unit tests coverage is sufficient for such a case.

@tdyas FYI

@bogdando bogdando marked this pull request as ready for review July 15, 2024 09:46
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from szuecs July 15, 2024 09:46
mloiseleur
mloiseleur reviewed Jul 22, 2024
View reviewed changes
charts/external-dns/CHANGELOG.md
@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Added support for `extraContainers` argument. ([#4432](https://github.com/kubernetes-sigs/external-dns/pull/4432)) _@omerap12_
- Added support for setting `excludeDomains` argument. ([#4380](https://github.com/kubernetes-sigs/external-dns/pull/4380)) _@bford-evs_
- Fixed reconciling `A` records that have more than 1 target for `rfc2136` provider. ([4613#](https://github.com/kubernetes-sigs/external-dns/pull/4613)) _@tdyas_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed reconciling `A` records that have more than 1 target for `rfc2136` provider. ([4613#](https://github.com/kubernetes-sigs/external-dns/pull/4613)) _@tdyas_

This changelog is for the helm chart

@mloiseleur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2024
@mloiseleur
Copy link
Contributor

@bogdando Would you please remove the line on the changelog ? Otherwise, the pr looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur left review comments

@johngmyers johngmyers Awaiting requested review from johngmyers

@szuecs szuecs Awaiting requested review from szuecs

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rfc2136 continually removing then adding A records that have more than 1 target
4 participants
@bogdando @k8s-ci-robot @mloiseleur @tdyas