Graceful handling of misconfigure password for dyn #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
linki
reviewed
Feb 20, 2018
| if cfg.DynMinTTLSeconds < 0 { | ||
| return errors.New("TTL specified for Dyn is negative") | ||
| } | ||
| } |
There was a problem hiding this comment.
@jvassev could you add tests for them in validation_test.go as well?
There was a problem hiding this comment.
Added the test, also another one testing the change from my previous commit.
If a bad password is given for provider "dyn" then the next login attempt is at least 30minutes apart. This prevents an account from being suspended. Improve validation of flags for dyn provider. Add test for ValidateConfig() and Config.String() Also add --dyn-min-ttl option which sets the lower limit of a record's TTL. Ignored if 0 (the default).
jvassev
force-pushed
the
bad-password
branch
from
0a5da84
to
61883b9
Compare
k8s-ci-robot
added
size/L
|
lgtm |
linki
added
the
lgtm
|
Thank you @jvassev |
grimmy
pushed a commit
to grimmy/external-dns
that referenced
this pull request
Apr 10, 2018
* Graceful handling of misconfigure password for dyn If a bad password is given for provider "dyn" then the next login attempt is at least 30minutes apart. This prevents an account from being suspended. Improve validation of flags for dyn provider. Add test for ValidateConfig() and Config.String() Also add --dyn-min-ttl option which sets the lower limit of a record's TTL. Ignored if 0 (the default). * docs: add graceful handling of misconfiguration to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bad password is given for provider "dyn" then the next
login attempt is at least 30minutes apart. This prevents an
account from being suspended.
Add validation of flags for dyn provider.
Also add --dyn-min-ttl option which sets the lower limit
of a record's TTL. Ignored if 0 (the default).
Removed a stale fmt.Println() statement.