Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build and delete vendor files which were not deleted #473

Merged
merged 4 commits into from
Feb 22, 2018

Conversation

njuettner
Copy link
Member

Docker was not able to build the image because dep was not installed

@njuettner njuettner requested a review from linki February 22, 2018 10:38
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2018
Copy link
Member

@linki linki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@linki linki added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2018
@linki
Copy link
Member

linki commented Feb 22, 2018

@njuettner still failing :(

@linki linki merged commit 06a8da0 into master Feb 22, 2018
@linki linki deleted the docker-fix branch February 22, 2018 12:19
grimmy pushed a commit to grimmy/external-dns that referenced this pull request Apr 10, 2018
…rnetes-sigs#473)

* Fix docker build and delete vendor files which were not deleted

* Fix docker build and delete vendor files which were not deleted

* Add me as a owner

* Fix docker build and delete vendor files which were not deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants