source/service: if clusterIP: None, set TTL #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Makes sense, can you add a test? |
k8s-ci-robot
added
size/M
|
Test added :) |
|
Looks like Not sure there's anything I can do on my end? |
|
Rebased master and all seems to be fine. |
hjacobs
approved these changes
May 8, 2018
|
Thanks! Does a new image get built and deployed or will this fix be in the next release? |
|
@danbondd the latest image is automatically built from master, please check https://registry.opensource.zalan.do/teams/teapot/artifacts/external-dns/tags A new release will also be cut (when?) to include the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF: #544
If the Service was set to
clusterIP: None, the generated endpoints would never use the configured TTL.I have tested this with the exact config in the above referenced issue and it now works as expected by setting the configured TTL.