Add aws max change count flag #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
peterbale
force-pushed
the
flag-aws-max-change-count
branch
from
697bd7a
to
706702a
Compare
|
Thank you for your PR @peterbale We'll have a look |
|
mind adding the change to the changelog ? |
Rather than calling `NewAWSProvider` with a list of objects, you will now call it using a new `AWSConfig` struct. This allows for clearer declarations of variables which becomes even more important as more variables are added.
Adding a new `aws-max-change-count` flag to override the default max change count on the aws provider. Included updated tests with a new `defaultMaxChangeCount` constant and tests for setting the value as a flag and as an environment variable.
peterbale
force-pushed
the
flag-aws-max-change-count
branch
from
402e7e2
to
4f5255c
Compare
Updating CHANGELOG.md with 'Add aws max change count flag' PR.
peterbale
force-pushed
the
flag-aws-max-change-count
branch
from
4f5255c
to
d65b568
Compare
linki
added
the
lgtm
|
Thanks @peterbale 👍 |
This was referenced Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new
aws-max-change-countflag to override the default maxchange count on the aws provider.
Included updated tests with a new
defaultMaxChangeCountconstant andtests for setting the value as a flag and as an environment variable.
Rather than calling
NewAWSProviderwith a list of objects, you willnow call it using a new
AWSConfigstruct. This allows for clearerdeclarations of variables which becomes even more important as more
variables are added.
Part of: #515