Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DO CNAME type API request to prevent error 422 #624

Merged
merged 2 commits into from
Jul 19, 2018

Conversation

nenadilic84
Copy link
Contributor

@nenadilic84 nenadilic84 commented Jul 4, 2018

For some reason, the DO API requires the '.' at the end of "data" in case of CNAME request
Example: {"type":"CNAME","name":"hello","data":"www.example.com."}
otherwise gives this error:
422 - Data needs to end with a dot (.)

For some reason, the DO API requires the '.' at the end of "data" in case of CNAME request
Example: {"type":"CNAME","name":"hello","data":"www.example.com."}
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2018
@njuettner njuettner self-assigned this Jul 4, 2018
@njuettner
Copy link
Member

Thank you for the PR 😄 !

Looks like other people have faced this issue as well, https://github.com/terraform-providers/terraform-provider-digitalocean/issues/58

Could you please sign the CLA first? I would also change the first comment to "422 - Data needs to end with a dot (.)"

I would also propose to add a test.

@njuettner
Copy link
Member

@nenadilic84 thank you for signing the CLA, could you please add a test case?

@njuettner njuettner added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 5, 2018
@nenadilic84
Copy link
Contributor Author

Sure, will do.

@njuettner
Copy link
Member

@nenadilic84 did you had time to look at the tests?

@njuettner
Copy link
Member

@nenadilic84 I've added a commit to your PR to add the test which covers the cange.
https://coveralls.io/builds/18064739/source?filename=provider/digital_ocean.go#L219

This looks good now 🙂 .

So thanks again for finding this bug 👍 .

@njuettner njuettner merged commit b9f7dd8 into kubernetes-sigs:master Jul 19, 2018
lou-lan pushed a commit to lou-lan/external-dns that referenced this pull request May 11, 2022
* Remove multi-index flag

* Add comment explaining why index is being modified

* Fix info example indentation

* Update install help message

* Make install help message more consistent

* Remove multi index flag from ci test

* Remove comment

* Move custom index example down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants