-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TLS issue with OpenStack auth (Designate) #717
Fix TLS issue with OpenStack auth (Designate) #717
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it |
97a3fcc
to
381b766
Compare
👋. Thanks for your PR 🙂 @FestivalBobcats. Does the tests still cover your change or do you need tests for that? |
Hi @njuettner, I didn't add or remove any functionality from the Designate provider, and it looks like only the implementation of the provider interface is tested. A test here would just assert that the OpenStack client was correctly initialized -- should I add that? |
@FestivalBobcats If you don't mind please add the test. This would be great 👍 |
@njuettner I added a test, but keep running into timeouts with |
Sometimes there's a timeout. I just triggered it again. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It appears as though the certificate options for OpenStack were only being configured for requests to Designate, and not for the initial authentication requests to Keystone. This change resolves that issue.