Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil map access of endpoint labels #739

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

shashidharatd
Copy link

We are seeing crash in latest code as below

panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/kubernetes-incubator/external-dns/registry.(*TXTRegistry).Records(0xc0001025b0, 0xc000000300, 0xc0006ed828, 0xc0004ca8a0, 0xc0004ca8a0, 0xc0006ed828)
	/go/src/github.com/kubernetes-incubator/external-dns/registry/txt.go:103 +0x49a
github.com/kubernetes-incubator/external-dns/controller.(*Controller).RunOnce(0xc0004c0b80, 0xc0006ed7f8, 0x2)
	/go/src/github.com/kubernetes-incubator/external-dns/controller/controller.go:67 +0x49
github.com/kubernetes-incubator/external-dns/controller.(*Controller).Run(0xc0004c0b80, 0xc000086960)
	/go/src/github.com/kubernetes-incubator/external-dns/controller/controller.go:100 +0x84
main.main()
	/go/src/github.com/kubernetes-incubator/external-dns/main.go:240 +0xb0e

probably this was introduced by #713

/cc @njuettner @linki

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2018
@njuettner
Copy link
Member

Thanks for your PR @shashidharatd 👍
We probably oversaw this case, nice catch!

@njuettner
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@njuettner
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit db13a3d into kubernetes-sigs:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants