Update Azure documentation #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hjacobs
reviewed
Oct 23, 2018
docs/tutorials/azure.md
Outdated
| { | ||
| "tenantId": "AzureAD tenant Id", | ||
| "subscriptionId": "Id", | ||
| "tenantId": "0f4e348f-8aef-4205-9d60-7a53e4ec3a3f", |
There was a problem hiding this comment.
you probably don't want to have (your?) private IDs in here... 😏
There was a problem hiding this comment.
No worries, that's uuidgen output. I wanted to have something that looks more like a real ID. But now I think it's better to change it to something that looks more like artifical data, will change it!
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
lou-lan
pushed a commit
to lou-lan/external-dns
that referenced
this pull request
May 11, 2022
* A modernization pass * Bump hugo * Set netlify 1.17 * Revert replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the new possibility for deployments without cluster access from #663 and also tried to improve the general Azure documentation a bit.