-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure documentation #756
Conversation
docs/tutorials/azure.md
Outdated
{ | ||
"tenantId": "AzureAD tenant Id", | ||
"subscriptionId": "Id", | ||
"tenantId": "0f4e348f-8aef-4205-9d60-7a53e4ec3a3f", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably don't want to have (your?) private IDs in here... 😏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, that's uuidgen
output. I wanted to have something that looks more like a real ID. But now I think it's better to change it to something that looks more like artifical data, will change it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* A modernization pass * Bump hugo * Set netlify 1.17 * Revert replace
I added the new possibility for deployments without cluster access from #663 and also tried to improve the general Azure documentation a bit.