panic: assignment to entry in nil map #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
cncf-cla: yes
njuettner
requested review from
linki
and removed request for
justinsb and
iterion
|
/assign @linki |
linki
reviewed
Nov 20, 2018
provider/google.go
Outdated
| RecordTTL: endpoint.TTL(r.Ttl), | ||
| } | ||
| targets := make(endpoint.Targets, 0, len(r.Rrdatas)) | ||
| ep := endpoint.NewEndpointWithTTL(strings.TrimSuffix(r.Name, "."), r.Type, endpoint.TTL(r.Ttl), targets...) |
There was a problem hiding this comment.
.TrimSuffixfor dnsName is already part ofNewEndpointWithTTLso we can leave it out here- we could also remove the subsequent
forforr.Rrdatasby passing in the rawr.Rrdatasas the last argument. refer to thecleanTargetsstuff inNewEndpointWithTTL(if I see that correctly at this time of day).
linki
reviewed
Nov 20, 2018
k8s-ci-robot
added
size/S
|
/assign @linki |
linki
reviewed
Nov 21, 2018
provider/google.go
Outdated
| sort.Sort(ep.Targets) | ||
| endpoints = append(endpoints, ep) | ||
| sort.Sort(targets) | ||
| endpoints = append(endpoints, endpoint.NewEndpointWithTTL(r.Name, r.Type, endpoint.TTL(r.Ttl), targets...)) |
There was a problem hiding this comment.
I think we can directly pass-in r.Rrdatas as the last argument here, can't we?
Remove sorting of rrdatas
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #729