Fix alibaba cloud config file missing by enable sts token #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
njuettner
reviewed
Apr 15, 2019
docs/tutorials/alibabacloud.md
Outdated
| @@ -379,3 +380,5 @@ Give ExternalDNS some time to clean up the DNS records for you. Then delete the | |||
| ```console | |||
| $ aliyun alidns DeleteDomain --DomainName external-dns-test.com | |||
| ``` | |||
|
|
|||
| For more info about Alibaba Cloud external dns, please refer this docs [link](https://yq.aliyun.com/articles/633412) | |||
njuettner
reviewed
Apr 15, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this flag, it will be error log below
For docs, the roles will enable sts token function , so add this flag.
Pls @njuettner take a look.