Make it a pointer type

kubernetes-sigs · Apr 18, 2024 · 07a0a93 · 07a0a93
1 parent f244632
commit 07a0a93
Show file tree

Hide file tree

Showing 8 changed files with 37 additions and 7 deletions.
diff --git a/apis/v1/grpcroute_types.go b/apis/v1/grpcroute_types.go
@@ -154,7 +154,8 @@ type GRPCRouteRule struct {
 	// Name is the name of the route rule. This name MUST be unique within a Route if it is set.
 	//
 	// Support: Extended
-	Name SectionName `json:"name,omitempty"`
+	// +optional
+	Name *SectionName `json:"name,omitempty"`
 
 	// Matches define conditions used for matching the rule against incoming
 	// gRPC requests. Each match is independent, i.e. this rule will be matched

diff --git a/apis/v1/httproute_types.go b/apis/v1/httproute_types.go
@@ -136,7 +136,8 @@ type HTTPRouteRule struct {
 	// Name is the name of the route rule. This name MUST be unique within a Route if it is set.
 	//
 	// Support: Extended
-	Name SectionName `json:"name,omitempty"`
+	// +optional
+	Name *SectionName `json:"name,omitempty"`
 
 	// Matches define conditions used for matching the rule against incoming
 	// HTTP requests. Each match is independent, i.e. this rule will be matched

diff --git a/apis/v1/zz_generated.deepcopy.go b/apis/v1/zz_generated.deepcopy.go
diff --git a/apis/v1alpha2/tcproute_types.go b/apis/v1alpha2/tcproute_types.go
@@ -63,7 +63,8 @@ type TCPRouteRule struct {
 	// Name is the name of the route rule. This name MUST be unique within a Route if it is set.
 	//
 	// Support: Extended
-	Name SectionName `json:"name,omitempty"`
+	// +optional
+	Name *SectionName `json:"name,omitempty"`
 
 	// BackendRefs defines the backend(s) where matching requests should be
 	// sent. If unspecified or invalid (refers to a non-existent resource or a

diff --git a/apis/v1alpha2/tlsroute_types.go b/apis/v1alpha2/tlsroute_types.go
@@ -104,7 +104,8 @@ type TLSRouteRule struct {
 	// Name is the name of the route rule. This name MUST be unique within a Route if it is set.
 	//
 	// Support: Extended
-	Name SectionName `json:"name,omitempty"`
+	// +optional
+	Name *SectionName `json:"name,omitempty"`
 
 	// BackendRefs defines the backend(s) where matching requests should be
 	// sent. If unspecified or invalid (refers to a non-existent resource or

diff --git a/apis/v1alpha2/udproute_types.go b/apis/v1alpha2/udproute_types.go
@@ -63,7 +63,8 @@ type UDPRouteRule struct {
 	// Name is the name of the route rule. This name MUST be unique within a Route if it is set.
 	//
 	// Support: Extended
-	Name SectionName `json:"name,omitempty"`
+	// +optional
+	Name *SectionName `json:"name,omitempty"`
 
 	// BackendRefs defines the backend(s) where matching requests should be
 	// sent. If unspecified or invalid (refers to a non-existent resource or a

diff --git a/apis/v1alpha2/zz_generated.deepcopy.go b/apis/v1alpha2/zz_generated.deepcopy.go
diff --git a/pkg/test/cel/httproute_test.go b/pkg/test/cel/httproute_test.go
@@ -1214,10 +1214,10 @@ func TestHTTPRouteRule(t *testing.T) {
 			wantErrors: []string{"Route name must be unique within the route"},
 			rules: []gatewayv1.HTTPRouteRule{
 				{
-					Name: "name1",
+					Name: ptrTo(gatewayv1.SectionName("name1")),
 				},
 				{
-					Name: "name1",
+					Name: ptrTo(gatewayv1.SectionName("name1")),
 				},
 			},
 		},