Skip to content

Commit

Permalink
replace Attached condition with Accepted in HTTPRoute docs
Browse files Browse the repository at this point in the history
The HTTPRoute docs have several references to
an "Attached" condition, however this condition
does not exist for routes. Replaces these
references with the appropriate "Accepted"
condition.

Signed-off-by: Steve Kriss <krisss@vmware.com>
  • Loading branch information
skriss committed Sep 26, 2022
1 parent a8f619d commit 2357da5
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 44 deletions.
8 changes: 4 additions & 4 deletions apis/v1alpha2/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type HTTPRouteRule = v1beta1.HTTPRouteRule
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;PathPrefix;RegularExpression
Expand Down Expand Up @@ -112,7 +112,7 @@ type HTTPPathMatch = v1beta1.HTTPPathMatch
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;RegularExpression
Expand Down Expand Up @@ -159,7 +159,7 @@ type HTTPHeaderMatch = v1beta1.HTTPHeaderMatch
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;RegularExpression
Expand Down Expand Up @@ -187,7 +187,7 @@ type HTTPQueryParamMatch = v1beta1.HTTPQueryParamMatch
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=GET;HEAD;POST;PUT;DELETE;CONNECT;OPTIONS;TRACE;PATCH
Expand Down
16 changes: 8 additions & 8 deletions apis/v1beta1/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ type HTTPRouteRule struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;PathPrefix;RegularExpression
Expand Down Expand Up @@ -319,7 +319,7 @@ type HTTPPathMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;RegularExpression
Expand Down Expand Up @@ -400,7 +400,7 @@ type HTTPHeaderMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=Exact;RegularExpression
Expand Down Expand Up @@ -468,7 +468,7 @@ type HTTPQueryParamMatch struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +kubebuilder:validation:Enum=GET;HEAD;POST;PUT;DELETE;CONNECT;OPTIONS;TRACE;PATCH
Expand Down Expand Up @@ -575,7 +575,7 @@ type HTTPRouteFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +unionDiscriminator
Expand Down Expand Up @@ -819,7 +819,7 @@ type HTTPPathModifier struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// <gateway:experimental>
Expand Down Expand Up @@ -863,7 +863,7 @@ type HTTPRequestRedirectFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +optional
Expand Down Expand Up @@ -906,7 +906,7 @@ type HTTPRequestRedirectFilter struct {
// must ensure that unknown values will not cause a crash.
//
// Unknown values here must result in the implementation setting the
// Attached Condition for the Route to `status: False`, with a
// Accepted Condition for the Route to `status: False`, with a
// Reason of `UnsupportedValue`.
//
// +optional
Expand Down
40 changes: 20 additions & 20 deletions config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2357da5

Please sign in to comment.