Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.5.x: Cherry-pick #1305 #1351

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Release 0.5.x: Cherry-pick #1305 #1351

merged 2 commits into from
Aug 22, 2022

Conversation

sunjayBhatia
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cherry-pick changes for #1305 to 0.5.x release branch, so that implementations can be conformant with main and the latest release.

Which issue(s) this PR fixes:

Fixes #1328

Does this PR introduce a user-facing change?:

NONE

@mlavacca @sunjayBhatia
Conformance: fix Listener ConditionReason
db8d6d5 
In the "GatewaySecretInvalidReferenceGrant" and "GatewaySecretMissingReferenceGrant" conformance tests for gateways, the expected condition has been
changed from InvalidCertificateRef to RefNotPermitted.

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @sunjayBhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2022
@sunjayBhatia sunjayBhatia mentioned this pull request Aug 22, 2022
Closed
shaneutt
shaneutt approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 22, 2022
@shaneutt shaneutt added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@sunjayBhatia
Copy link
Member Author

Also had to cherry-pick a348ccf to fix codegen

lmk if this should be a separate PR

shaneutt
shaneutt approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d05e07b into kubernetes-sigs:release-0.5 Aug 22, 2022
@sunjayBhatia sunjayBhatia deleted the cherry-pick-0.5-1305 branch August 22, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@howardjohn howardjohn Awaiting requested review from howardjohn

@robscott robscott Awaiting requested review from robscott

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sunjayBhatia @k8s-ci-robot @shaneutt @mlavacca @robscott