Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing webhook config to watch v1beta1 #1365

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
As pointed out by @markmc, we missed updating the webhook config to include v1beta1 when we released v0.5.0.

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@sunjayBhatia
Copy link
Member

candidate for a backport for 0.5.x?

@robscott
Copy link
Member Author

candidate for a backport for 0.5.x?

Yep, definitely should backport this.

@markmc
Copy link
Contributor

markmc commented Aug 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3736448 into kubernetes-sigs:main Aug 30, 2022
@sunjayBhatia
Copy link
Member

candidate for a backport for 0.5.x?

Yep, definitely should backport this.

submitted #1368

k8s-ci-robot added a commit that referenced this pull request Aug 30, 2022
release-0.5: Cherry pick #1365 - Fixing webhook config to watch v1beta1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants