-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying HTTPRoute exact match behavior #2055
Clarifying HTTPRoute exact match behavior #2055
Conversation
Whenever this gets in, it also needs to go to v0.7.1. /cherry-pick release-0.7 |
@robscott: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/cc @michaelbeaumont @sunjayBhatia @arkodg @Xunzhuo
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelbeaumont, mlavacca, robscott, shaneutt, sunjayBhatia, Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
@robscott: new pull request created: #2056 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
/area conformance
What this PR does / why we need it:
This clarifies that exact path matches in HTTPRoute are truly exact. Both trailing slashes and capitalization are meaningful. This matches the consensus on #1953 and from our community meeting today. It also largely matches what our conformance tests already covered, this just slightly expands that coverage.
Which issue(s) this PR fixes:
Fixes #1953
Does this PR introduce a user-facing change?: