Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo GatewaReason -> GatewayReason #2149

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix typo GatewaReason -> GatewayReason #2149

merged 1 commit into from
Jun 28, 2023

Conversation

panslava
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fixes typo GatewaReasonUnsupportedAddress -> GatewayReasonUnsupportedAddress

Does this PR introduce a user-facing change?:

Fix typo: rename GatewaReasonUnsupportedAddress -> GatewayReasonUnsupportedAddress

I am not sure, how safe is that to do that

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 27, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @panslava. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shaneutt
shaneutt approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear... yeah we'll need to update that. Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: panslava, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt shaneutt added this to the v1.0.0 milestone Jun 27, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@shaneutt shaneutt added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2023
@shaneutt shaneutt self-assigned this Jun 27, 2023
@panslava
Copy link
Contributor Author

Thanks! I have some problems running full make locally, but make generate does not create new files, also CI failure seems like a flake? I will try to retest

/retest

@robscott
Copy link
Member

Thanks @panslava! Everything looks good on your end - appears to be an error pulling golang:1.20 image, hoping it's resolved by tomorrow, but if not, we can look into this more closely.

@panslava
Copy link
Contributor Author

/retest

@robscott
Copy link
Member

Thanks @panslava!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2023
@robscott robscott modified the milestones: v1.0.0, v0.8.0 Jun 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 543609a into kubernetes-sigs:main Jun 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

Assignees

@robscott robscott

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@panslava @k8s-ci-robot @robscott @shaneutt