Using "Set" list type for "Remove" in Header Modifier Filters #2306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This fills one more gap in our CRD validation that we've historically relied on the validating webhook to cover. As documented in #2277, the webhook ensures that header names have case-insensitive uniqueness. The built-in CRD validation uses
+listType=map
and+listMapKey=name
to ensure that names are unique (unfortunately still case-sensitive, but better than nothing). We were missing equivalent CRD validation on theRemove
field, this adds that.As we're moving away from webhook-based validation, adding as much validation we can directly to the CRD will be helpful, so this takes one more step in that direction.
Does this PR introduce a user-facing change?: