-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gateway-api-crds chart #2951
feat: add gateway-api-crds chart #2951
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: networkhermit The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @networkhermit. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably on me for not communicating it very well in the relevant issue, but I was kinda hoping we would have a bit more discussion before we added a Helm chart. To be clear, I'm generally hesitant to add Helm charts here.
That said, I remain open to suggestion. I would like to give this some time to see what others think.
/hold
I would ask that we get this topic on the agenda for an upcoming community sync, as I think it would be good to discuss it there at least a bit.
Hey @networkhermit, thanks for working on this! To clarify, we can't include CRDs directly in a helm chart safely. On the other hand, we would consider including a helm chart that deployed something like a Job that installed CRDs (x-ref #2678). Before we start on a helm chart we really need to solve #2678 though, and that's going to require some additional thought around if/how we deal with transitions between release channels. Sorry for any confusion here, let us know if you're interested in working on #2678 though. |
Never mind. It's only a poc to emulate prometheus-operator-crds like installation process. I did it to see if it can ease the iac/gitops bootstrap (see envoyproxy/gateway#1721 (comment) for an example). It doesn't have to be the official supported method.
Well. I think #2678 is not simple as it described. I'm not an expert in Gateway API so I doubt I can handle the complexity and meet all the safety and backwards compatibility guarantees, especially the multiple competing implementations situation. I'm not sure using a job to bootstrap the gateway api crds is possible before the CNI get ready first. As that is the case to bootstrap cilium to use its gateway api support. I'm testing different implementations to better learn Gateway API. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Hi @networkhermit, are you still interested in working on this one? If you need any help, feel free to reach out. |
I don't think there is established consensus among the gateway-api community to adopt this naive implementation, see #2678 and #1590 (comment) for more context. Due to the hard requirements and the close collaboration with other maintainers, I don't think I have enough time and energy to tackle it. With that said, feel free to adopt my draft implementation if anyone need it. |
Yep, I am aware of the context behind this. We are trying to perform some cleanup among the staled PRs and issues, so I'll close this PR. In case the scope of this issue becomes clearer and you want to get back on it, feel free to re-open it. /close |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1590
Does this PR introduce a user-facing change?:
Summary
Inspired by the following great resources:
TODO
skip_upload
, we can wait for them to release a new version, or just pin the version to commit hash which is used by this prDemo usage:
check chart packaging content:
install gateway-api-crds:
uninstall gateway-api-crds: