-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add backend protocol to implementers guide #3176
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Joel Roberts <joerober@cisco.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joerober The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @joerober! |
Hi @joerober. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/assign @youngnick @shaneutt @robscott I believe this is the last bit for the backend protocol selection GEP. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joerober!
|
||
## Backend Protocol | ||
|
||
Not all implementations of Gateway API support automatic protocol selection. In some cases protocols are disabled without an explicit opt-in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It would be good to reword this to focus on the context that this is the Implementer's Guide, and thus intended for implementers to read. What do implementers need to know about this feature? I think the focus in this guide should be to talk about how you might implement it, what this concept usually maps to in common underlying dataplanes like Envoy or NGINX, and where implementers can find more information (I think you already have that part in "References", but it might be good to have more specifics such as the well defined protocols that we recommend implementations support. It would also be good to include keywords such as websockets and HTTP/2 for implementers that may be looking for how to support these concepts with their Gateway API implementation.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds section on backend protocol selection to implementors guide explaining that backend protocol selection exists with link to user guide and link to supporting protocols in GEP-1911.
Which issue(s) this PR fixes:
Fixes #2453
Does this PR introduce a user-facing change?: