-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make update-codegen.sh runnable on Mac #3186
Conversation
`uname -o` isn't supported on Mac. Here is the output of `man uname`: ``` UNAME(1) General Commands Manual UNAME(1) NAME uname – Print operating system name SYNOPSIS uname [-amnprsv] DESCRIPTION The uname utility writes symbols representing one or more system characteristics to the standard output. The following options are available: -a Behave as though all of the options -mnrsv were specified. -m print the machine hardware name. -n print the nodename (the nodename may be a name that the system is known by to a communications network). -p print the machine processor architecture name. -r print the operating system release. -s print the operating system name. -v print the operating system version. If no options are specified, uname prints the operating system name as if the -s option had been specified. SEE ALSO hostname(1), machine(1), sw_vers(1), uname(3) STANDARDS The uname utility conforms to IEEE Std 1003.2-1992 (“POSIX.2”). The -p option is an extension to the standard. macOS 12.6 November 9, 1998 macOS 12.6 ``` Also fix a passthrough bug when the script is running on Unsupported OS. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Hi @spacewander. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
SGTM /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spacewander, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Thanks @spacewander! /lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
uname -o
isn't supported on Mac. Here is the output ofman uname
:Also fix a passthrough bug when the script is running on Unsupported OS.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: