Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEP-2907: TLS mode and allowed routes #3190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Jul 8, 2024

What type of PR is this?

/kind gep

What this PR does / why we need it:

This PR updates GEP-2907 with two different aspects:

  • definition of TLS mode (Terminate and Passthrough)
  • what routes can be attached to Listeners that specify TLS configuration.

This PR intends to reach an agreement that will make #2111 and #1474 addressable.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Jul 8, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2024
@mlavacca
Copy link
Member Author

mlavacca commented Jul 8, 2024

/cc @candita

@k8s-ci-robot k8s-ci-robot requested a review from candita July 8, 2024 07:24
@mlavacca
Copy link
Member Author

mlavacca commented Jul 8, 2024

I have no idea why the CI robot has put this in hold 🤔

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
geps/gep-2907/index.md Outdated Show resolved Hide resolved
| `HTTPRoute` | yes | no |
| `GRPCRoute` | yes | no |
| `TLSRoute` | yes | yes |
| `TCPRoute` | yes | yes |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is passthrough mode on a TCPRoute based on what we see in

TLS *GatewayTLSConfig `json:"tls,omitempty"`
, or something else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. it says It is invalid to set this field if the Protocol field is "HTTP", "TCP", or "UDP".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was based on a discussion we had about enabling TLS on TCPRoute. But I think that at least for the time being, even considering the high level of uncertainty the L4 routes have at the moment, we should be aligned with the current API specs, without aiming at improving it.

@mlavacca
Copy link
Member Author

mlavacca commented Aug 9, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 9, 2024
@mlavacca mlavacca requested a review from candita August 9, 2024 14:56
@mlavacca
Copy link
Member Author

mlavacca commented Aug 9, 2024

/retest

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
| `HTTPRoute` | yes | no |
| `GRPCRoute` | yes | no |
| `TLSRoute` | yes | yes |
| `TCPRoute` | no | no |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need a note here that for TCPRoute, the packets are passed through untouched to the backend. If you want to terminate a TLS stream at a Gateway and forward a TCP stream unencrypted to the backend, use TLSRoute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants