-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v1.1.0 conformance report for envoy gateway v1.1.0 #3191
Conversation
/area conformance |
49eb84f
to
3014206
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @Xunzhuo!
supportedFeatures: | ||
- GatewayHTTPListenerIsolation | ||
- GatewayPort8080 | ||
- GatewayStaticAddresses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why set this feature to skip the underlying test?
|-----------|----------------------|----|------| | ||
| experimental |[v1.1.0-rc.1](https://github.com/envoyproxy/gateway/releases/tag/v1.1.0-rc.1)| default |[link](./experimental-v1.1.0-rc.1-default-report.yaml)| | ||
|
||
## Reproduce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the needed steps to reproduce the claimed report?
Thanks @mlavacca, I will update this PR, after EG release v1.1 : ) |
hey @Xunzhuo can you update this PR to v1.1.0 |
Signed-off-by: bitliu <bitliu@tencent.com>
/cc @arkodg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg, mlavacca, Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hey @Xunzhuo noticing that envoy gateway does not show up in the GRPCRoute section |
Signed-off-by: bitliu <bitliu@tencent.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Add v1.1.0 conformance report for envoy gateway v1.1.0
Does this PR introduce a user-facing change?: