Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1.1.0 conformance report for envoy gateway v1.1.0 #3191

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add v1.1.0 conformance report for envoy gateway v1.1.0 #3191

merged 1 commit into from
Jul 30, 2024

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Jul 10, 2024 •
edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Add v1.1.0 conformance report for envoy gateway v1.1.0

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Jul 10, 2024

/area conformance

@Xunzhuo Xunzhuo force-pushed the add-report branch 2 times, most recently from 49eb84f to 3014206 Compare July 10, 2024 11:21
@Xunzhuo Xunzhuo changed the title feat: add v1.1.0 conformance report for envoy gateway v1.1.0-rc.1 Add v1.1.0 conformance report for envoy gateway v1.1.0-rc.1 Jul 10, 2024
mlavacca
mlavacca reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @Xunzhuo!

conformance/reports/v1.1.0/envoy-gateway/experimental-v1.1.0-rc.1-default-report.yaml Outdated
supportedFeatures:
- GatewayHTTPListenerIsolation
- GatewayPort8080
- GatewayStaticAddresses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why set this feature to skip the underlying test?

conformance/reports/v1.1.0/envoy-gateway/README.md
|-----------|----------------------|----|------|
| experimental |[v1.1.0-rc.1](https://github.com/envoyproxy/gateway/releases/tag/v1.1.0-rc.1)| default |[link](./experimental-v1.1.0-rc.1-default-report.yaml)|

## Reproduce
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the needed steps to reproduce the claimed report?

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Jul 17, 2024

Thanks @mlavacca, I will update this PR, after EG release v1.1 : )

@arkodg
Copy link
Contributor

arkodg commented Jul 29, 2024

hey @Xunzhuo can you update this PR to v1.1.0

@Xunzhuo
profile: add conformance reports for eg v1.1
3d597ba 
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo changed the title Add v1.1.0 conformance report for envoy gateway v1.1.0-rc.1 Add v1.1.0 conformance report for envoy gateway v1.1.0 Jul 30, 2024
@Xunzhuo Xunzhuo requested a review from mlavacca July 30, 2024 06:48
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2024
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Jul 30, 2024

/cc @arkodg

@k8s-ci-robot k8s-ci-robot requested a review from arkodg July 30, 2024 06:49
mlavacca
mlavacca approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Xunzhuo!

/approve

I'll let @arkodg put the lgtm stamp.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2024
arkodg
arkodg approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, mlavacca, Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c94d401 into kubernetes-sigs:main Jul 30, 2024
8 checks passed
@arkodg
Copy link
Contributor

arkodg commented Jul 30, 2024

hey @Xunzhuo noticing that envoy gateway does not show up in the GRPCRoute section
https://gateway-api.sigs.k8s.io/implementations/v1.1/, can you help investigate this further ?

@Xunzhuo Xunzhuo mentioned this pull request Jul 31, 2024
Merged
xtineskim pushed a commit to xtineskim/gateway-api that referenced this pull request Aug 8, 2024
@Xunzhuo @xtineskim
profile: add conformance reports for eg v1.1 (kubernetes-sigs#3191)
bc94a5a 
Signed-off-by: bitliu <bitliu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

@mlavacca mlavacca mlavacca approved these changes

@kflynn kflynn Awaiting requested review from kflynn

Assignees

@arkodg arkodg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Xunzhuo @arkodg @k8s-ci-robot @mlavacca