-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conformance tests for in-cluster Gateway infrastructure #3192
Add conformance tests for in-cluster Gateway infrastructure #3192
Conversation
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
/retest |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@arkodg can you let me know if Envoy Gateway can pass these conformance tests? |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 from ciliium team, Thanks for adding this test 👍
…ource Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✔️
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: keithmattix, robscott, sayboras The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks everyone! |
…es-sigs#3192) * Add conformance tests for in-cluster Gateway infrastructure Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Fix lint and type errors Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * gofmt Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Check services as well Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Promote GEP to standard Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Add boilerplate Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Fix args Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> * Rewrite logic to check for metadata propagation for each matching resource Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> --------- Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
What type of PR is this?
/area conformance
/kind test
What this PR does / why we need it:
Adds conformance tests to move in-cluster Gateway deployments GEP to standard
Which issue(s) this PR fixes:
Part of #1762
Does this PR introduce a user-facing change?: