Add inherited policies for Gateway and Backends #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/gwctl
approved
k8s-ci-robot
added
the
needs-rebase
gwctl/pkg/printer/backends_test.go
Outdated
| }, | ||
| "spec": map[string]interface{}{ | ||
| "default": map[string]interface{}{ | ||
| "key2": "value-parent-2", |
There was a problem hiding this comment.
Worth adding an example of a default "key1": "value-parent-1" here perhaps, to highlight the difference between an override vs a default inherited from the gateway?
Suggested change
| "key2": "value-parent-2", | |
| "key1": "value-parent-1", | |
| "key2": "value-parent-2", |
gauravkghildiyal
force-pushed
the
gw-and-backend-inherited-policies
branch
from
940d66a
to
1a1fbbc
Compare
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add inherited policies for Gateway and Backends. Refer test cases for sample outputs
/hold
Does this PR introduce a user-facing change?: