-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inherited policies for Gateway and Backends #3198
Add inherited policies for Gateway and Backends #3198
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gwctl/pkg/printer/backends_test.go
Outdated
}, | ||
"spec": map[string]interface{}{ | ||
"default": map[string]interface{}{ | ||
"key2": "value-parent-2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding an example of a default "key1": "value-parent-1"
here perhaps, to highlight the difference between an override vs a default inherited from the gateway?
"key2": "value-parent-2", | |
"key1": "value-parent-1", | |
"key2": "value-parent-2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Done.
940d66a
to
1a1fbbc
Compare
/lgtm |
/unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add inherited policies for Gateway and Backends. Refer test cases for sample outputs
/hold
Does this PR introduce a user-facing change?: