Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Update Gateway.Spec.Listener[x].Routes.Selector to be a pointer #572

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

stevesloka
Copy link
Contributor

What type of PR is this?
/kind bug
/kind api-change

What this PR does / why we need it:

The Gateway.Spec.Listener[x].Routes.Selector is not a pointer and should be.

Which issue(s) this PR fixes:
Fixes #571

Does this PR introduce a user-facing change?:

Update Gateway.Spec.Listener[x].Routes.Selector to be a pointer.

//cc @danehans

Signed-off-by: Steve Sloka slokas@vmware.com

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Mar 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @stevesloka. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 3, 2021
@stevesloka
Copy link
Contributor Author

I'm struggling to get the docs to regen. My mac just won't get the right bits to work. Could we have an optional docker build step to run those in docker removing the need for local deps?

@robscott
Copy link
Member

robscott commented Mar 3, 2021

@stevesloka No need for docs generation at all anymore, we've moved to Netlify. Deploy previews are available from "deploy/preview" presubmit (this one is https://deploy-preview-572--kubernetes-sigs-gateway-api.netlify.app/).

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2021
@stevesloka
Copy link
Contributor Author

No need for docs generation at all anymore

w00t! Thanks @robscott! =)

@robscott
Copy link
Member

robscott commented Mar 3, 2021

Unfortunately k8s infra doesn't like fixes keywords in commit messages so this can't be merged until that is removed. (kubernetes/test-infra#9360)

Signed-off-by: Steve Sloka <slokas@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 3, 2021
@stevesloka
Copy link
Contributor Author

Sorry, it's a habit @robscott. I updated the commit message to remove that.

@hbagdi
Copy link
Contributor

hbagdi commented Mar 4, 2021

Like #564, this is another case of an optional struct should be a pointer.
We discussed previously that we need to audit the entire code to ensure this is the case.
I think we should certainly do that but such small improvements are also good.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@bowei
Copy link
Contributor

bowei commented Mar 9, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, stevesloka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit a01a54b into kubernetes-sigs:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway.Spec.Listener[x].Routes.Selector should be a pointer
5 participants