Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value "/" for HTTPPathMatch #584

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

nak3
Copy link
Member

@nak3 nak3 commented Mar 14, 2021

What this PR does / why we need it:

HTTPPathMatch has a default prefix match on the "/" path.
For example, if match was not configured, the default prefix match with value will be filled.

(This configuration works.)

spec:
  rules:

However, once we added type such as Prefix or Exact, the value
field must be filled by ourselves.

(This configuration does not work due to missing value field.)

spec:
  rules:
    matches:
    - path:
        type: Prefix

Hence this patch adds the default / value for path.value.

What type of PR is this?

/kind api-change

Does this PR introduce a user-facing change?:

HTTPPathMatch path.value sets default value "/" when type was configured but value was not.

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nak3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2021
@robscott
Copy link
Member

Thanks! This makes sense to me, assigning to @danehans to be sure.

/ok-to-test
/lgtm
/assign @danehans

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2021
@danehans
Copy link
Contributor

@nak3 thanks for catching this issue. Since value is being defaulted at higher layers of the API, it should be defaulted and be set to optional directly on the field.

/lgtm when #584 (comment) is resolved.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
`HTTPPathMatch` has a default `prefix match on the "/" path`.
For example, if `match` was not provided, the default value will be filled.

(This configuration works.)
```
spec:
  rules:
```

However, once we added `type` such as `Prefix` or `Exact`, the `value`
field must be filled by ourselves.

(This configuration does not work.)
```
spec:
  rules:
    matches:
    - path:
        type: Prefix
```

This patch adds the default `/` value for `path.value`.
@robscott
Copy link
Member

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 941868f into kubernetes-sigs:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants