-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default value "/" for HTTPPathMatch #584
Conversation
Hi @nak3. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nak3 thanks for catching this issue. Since /lgtm when #584 (comment) is resolved. |
`HTTPPathMatch` has a default `prefix match on the "/" path`. For example, if `match` was not provided, the default value will be filled. (This configuration works.) ``` spec: rules: ``` However, once we added `type` such as `Prefix` or `Exact`, the `value` field must be filled by ourselves. (This configuration does not work.) ``` spec: rules: matches: - path: type: Prefix ``` This patch adds the default `/` value for `path.value`.
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
HTTPPathMatch
has a defaultprefix match on the "/" path
.For example, if
match
was not configured, the default prefix match with value will be filled.(This configuration works.)
However, once we added
type
such asPrefix
orExact
, thevalue
field must be filled by ourselves.
(This configuration does not work due to missing
value
field.)Hence this patch adds the default
/
value forpath.value
.What type of PR is this?
/kind api-change
Does this PR introduce a user-facing change?: