Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md for v0.4.0-rc1 #791

Merged
merged 5 commits into from
Aug 26, 2021
Merged

Update CHANGELOG.md for v0.4.0-rc1 #791

merged 5 commits into from
Aug 26, 2021

Conversation

youngnick
Copy link
Contributor

Signed-off-by: Nick Young ynick@vmware.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Updates CHANGELOG.md for a v0.4.0-rc1 release, so that implementations can get started with integration asap.

This is a preview of the full v0.4.0 changelog, we won't reprint the full thing until the actual release.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@robscott
Copy link
Member

This looks great, thanks for the great changelog @youngnick! Adding a hold until we get at least one more maintainer to sign off on this release candidate. Once this PR goes in, we should not merge any additional PRs until we cut a release.

/cc @bowei @hbagdi @jpeach
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@robscott
Copy link
Member

I'm holding out a tiny bit of hope that we can sneak in #772 before this RC goes out, but that should not block this at all. Thanks for all the work on this - I'm excited to get a release candidate out.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@robscott
Copy link
Member

Actually, let's hold off on this RC until we've given sig-net reviewers a bit more time to look at the API, want to make sure there are not any major concerns from them first. Maybe we can target early next week for this? I think we should have a bit more feedback by then.

@youngnick
Copy link
Contributor Author

I think that early next week is a good target.

hbagdi
hbagdi reviewed Aug 20, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Nick Young added 2 commits August 24, 2021 07:42
Update CHANGELOG.md for v0.4.0-rc1
cafc2c7 
Signed-off-by: Nick Young <ynick@vmware.com>
Update line breaks to 80 characters or so
339b898 
Signed-off-by: Nick Young <ynick@vmware.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2021
@robscott
Copy link
Member

robscott commented Aug 25, 2021 •
edited
Loading

Thanks for the work on this @youngnick! I think we just need to incorporate the changes from #796 into this and we'll be good to go:

  • listener.routes has been renamed to listener.allowedRoutes
  • The "NoSuchGatewayClass" has been removed after it was deprecated in v1alpha1
  • "*" is no longer a valid hostname. Instead, leaving hostname unspecified is interpreted as "*".

Maybe we can target a RC1 release tomorrow?

Add in changes from kubernetes-sigs#796
0def934 
Signed-off-by: Nick Young <ynick@vmware.com>
@youngnick
Copy link
Contributor Author

Needs #830 to pass CI.

@robscott
Copy link
Member

/retest

Update initial notice to be more clear
54443aa 
Signed-off-by: Nick Young <ynick@vmware.com>
robscott
robscott reviewed Aug 26, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@youngnick youngnick added this to the v1alpha2 milestone Aug 26, 2021
@robscott
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
jpeach
jpeach reviewed Aug 26, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
Fix further feedback
fc3a44e 
Signed-off-by: Nick Young <ynick@vmware.com>
jpeach
jpeach reviewed Aug 26, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
jpeach
jpeach reviewed Aug 26, 2021
View reviewed changes
Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
@robscott
Copy link
Member

Thanks!

/lgtm

@youngnick
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 21aef06 into kubernetes-sigs:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach left review comments

@robscott robscott robscott left review comments

@hbagdi hbagdi hbagdi left review comments

@bowei bowei Awaiting requested review from bowei

Assignees

@jpeach jpeach

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1alpha2
Development

Successfully merging this pull request may close these issues.
5 participants
@youngnick @k8s-ci-robot @robscott @jpeach @hbagdi