Bump CSI External Components to v0.3.0+ and turn on Kubelet Registration #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
msau42
reviewed
Sep 27, 2018
| args: | ||
| - "--v=5" | ||
| - "--provisioner=csi-gce-pd" | ||
| - "--provisioner=com.google.csi.gcepd" |
There was a problem hiding this comment.
you don't need to set provisioner name
There was a problem hiding this comment.
davidz627
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
davidz627
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@msau42 ready for review |
msau42
reviewed
Sep 28, 2018
davidz627
force-pushed
the
feature/bumpExternalComponents
branch
from
bfa77c6 to
0532e86
Compare
davidz627
force-pushed
the
feature/bumpExternalComponents
branch
from
0532e86 to
874f582
Compare
|
@msau42 comments addressed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #116
Fixes: #92
Turns on Kubelet Registration which is required for interop with Kubernetes 1.12+
/assign @msau42