Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the testgrid dashboard url from "k8s-testgrid.appspot.com" to… #1367

Closed
wants to merge 3 commits into from
Closed

updated the testgrid dashboard url from "k8s-testgrid.appspot.com" to… #1367

wants to merge 3 commits into from

Conversation

FZhg
Copy link

@FZhg FZhg commented Sep 5, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Updated the mentions of testgrid dashboard url to "testgrid.k8s.io" to eliminate 404-page-not-found error

Which issue(s) this PR fixes:
Completed a task in the umbrella issue:kubernetes/test-infra#30370

Fixed #1366

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @FZhg!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @FZhg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FZhg
Once this PR has been reviewed and has the lgtm label, please assign pwschuurman for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and pohly September 5, 2023 11:43
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2023
@FZhg
Copy link
Author

FZhg commented Sep 5, 2023

/assign

@letmerecall letmerecall mentioned this pull request Sep 7, 2023
Closed
40 tasks
msau42
msau42 reviewed Sep 12, 2023
View reviewed changes
release-tools/SIDECAR_RELEASE_PROCESS.md
@@ -17,7 +17,7 @@ The release manager must:
Whenever a new Kubernetes minor version is released, our kubernetes-csi CI jobs
must be updated.

[Our CI jobs](https://k8s-testgrid.appspot.com/sig-storage-csi-ci) have the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a git subtree so should be updated according to the steps here: https://github.com/kubernetes-csi/csi-release-tools/tree/master#sharing-and-updating

@FZhg FZhg closed this Sep 14, 2023
@FZhg FZhg reopened this Sep 14, 2023
@ameukam
Copy link
Member

ameukam commented Sep 19, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 19, 2023
@FZhg
Copy link
Author

FZhg commented Sep 19, 2023

/retest

@k8s-ci-robot
Copy link
Contributor

@FZhg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e ebb7257 link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration ebb7257 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 19, 2023
FZhg added 2 commits September 19, 2023 19:44
@FZhg
Squashed 'release-tools/' changes from 78c0fb71..984feece
c3f90e1 
984feece Merge pull request #234 from siddhikhapare/csi-tools
1f7e6059 fixed broken links of testgrid dashboard
de2fba88 Merge pull request #233 from andyzhangx/andyzhangx-patch-1
cee895e1 remove windows 20H2 build since it's EOL long time ago
670bb0ef Merge pull request #229 from marosset/fix-codespell-errors
35d5e783 Merge pull request #219 from yashsingh74/update-registry
63473cc9 Merge pull request #231 from coulof/bump-go-version-1.20.5
29a5c76c Merge pull request #228 from mowangdk/chore/adopt_kubernetes_recommand_labels
8dd28211 Update cloudbuild image with go 1.20.5
1df23dba Merge pull request #230 from msau42/prow
1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests
2b8b80ea fixing some codespell errors
c10b6780 Merge pull request #227 from coulof/check-sidecar-supported-versions
72984ec0 chore: adopt kubernetes recommand label
b0555351 Header
bd0a10b6 typo
c39d73c3 Add comments
f6491af0 Script to verify EOL sidecar version
4133d1df Merge pull request #226 from msau42/cloudbuild
8d519d23 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest
6e04a030 Merge pull request #224 from msau42/cloudbuild
26fdfffd Update cloudbuild image
6613c398 Merge pull request #223 from sunnylovestiramisu/update
0e7ae993 Update k8s image repo url
77e47cce Merge pull request #222 from xinydev/fix-dep-version
155854b0 Fix dep version mismatch
8f839056 Merge pull request #221 from sunnylovestiramisu/go-update
1d3f94dd Update go version to 1.20 to match k/k v1.27
e322ce5e Merge pull request #220 from andyzhangx/fix-golint-error
b74a5120 test: fix golint error
901bcb5a Update registry k8s.gcr.io -> registry.k8s.io
aa61bfd0 Merge pull request #218 from xing-yang/update_csi_driver
7563d196 Update CSI_PROW_DRIVER_VERSION to v1.11.0
a2171bef Merge pull request #216 from msau42/process
cb987826 Merge pull request #217 from msau42/owners
a11216e4 add new reviewers and remove inactive reviewers
dd986754 Add step for checking builds
b66c0824 Merge pull request #214 from pohly/junit-fixes
b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit
d4277839 filter-junit.go: preserve system error log
38e11468 prow.sh: publish individual JUnit files as separate artifacts

git-subtree-dir: release-tools
git-subtree-split: 984feece4bafac3aad74deeed76a500a0c485fb1
@FZhg
Merge commit 'c3f90e16533c015cffb75d009ed82b4b1caf9b95' into Update-t…
78eb533 
…estgrid-dashboard-URL-to-testgrid.k8s.io
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2023
@FZhg
Copy link
Author

FZhg commented Sep 19, 2023

/retest

@FZhg FZhg closed this Sep 19, 2023
@FZhg
Copy link
Author

FZhg commented Sep 19, 2023

Close due to Failing CI tests. I will open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@pohly pohly Awaiting requested review from pohly

Assignees

@FZhg FZhg

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testgrid Dashboard URL in the documentations are outdated
4 participants
@FZhg @k8s-ci-robot @ameukam @msau42