-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve probes to avoid cluster disturbance #162
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think it should be possible to update HNC with a rolling update without any cluster disturbance. Some of the webhooks in HNC intercepts a great percentage of API requests, and there should always be (at least) one webhook endpoint ready to serve requests at any time (after the initial bootstrapping of HNC).
Some probes were introduced in #139, but they are not "deep" enough, and just checks that the webhook server in HNC is available network-wise. I think some of the webhooks require the forest to be fully synced before the webhook can give a reasonable response to the API server request. And I think the probes should check that HNC is really ready to serve requests before the probe is successful.
The text was updated successfully, but these errors were encountered: