Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for K8s 1.22+ #133

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Update dependencies for K8s 1.22+ #133

merged 1 commit into from
Jan 27, 2022

Conversation

adrianludwin
Copy link
Contributor

The current version of cert-controller won't work on K8s 1.22+ since it
uses the removed v1beta CRD API. This change picks up the latest
cert-controller and all the other key latest dependencies.

Key updates:

  • controller-runtime to v0.11
  • cert-controller to the latest to pick up CRD v1beta removal
  • K8s client libs to 1.23
  • controller-tools to latest
  • Various other small changes

Tested: smoke tests

@adrianludwin
Update dependencies for K8s 1.22+
c210087 
The current version of cert-controller won't work on K8s 1.22+ since it
uses the removed v1beta CRD API. This change picks up the latest
cert-controller and all the other key latest dependencies.

Key updates:
* controller-runtime to v0.11
* cert-controller to the latest to pick up CRD v1beta removal
* K8s client libs to 1.23
* controller-tools to latest
* Various other small changes

Tested: smoke tests
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2022
@adrianludwin
Copy link
Contributor Author

/assign @rjbez17
/cc @erikgb

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

@adrianludwin: GitHub didn't allow me to request PR reviews from the following users: erikgb.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @rjbez17
/cc @erikgb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adrianludwin adrianludwin added this to the release-v1.0 milestone Jan 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022
@erikgb
Copy link
Contributor

erikgb commented Jan 26, 2022

FYI: We have experienced issues upgrading our controllers to controller-runtime 0.11.0 and K8s 1.23. See kubernetes-sigs/controller-runtime#1786. Might not be an issue here, but we decided to revert the upgrade - at least for now.

@erikgb
Copy link
Contributor

erikgb commented Jan 26, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

@erikgb: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rjbez17
Copy link
Contributor

rjbez17 commented Jan 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit aeca2e7 into kubernetes-sigs:master Jan 27, 2022
@adrianludwin adrianludwin deleted the deps branch March 24, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbez17 rjbez17 Awaiting requested review from rjbez17

@tashimi tashimi Awaiting requested review from tashimi

Assignees

@rjbez17 rjbez17

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
release-v1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adrianludwin @k8s-ci-robot @erikgb @rjbez17