Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add liveness and startup/readiness probes #139

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add liveness and startup/readiness probes #139

merged 1 commit into from
Mar 16, 2022

Commits on Mar 6, 2022

  1. Add liveness and startup/readiness probes 

    This adds liveness and startup/readiness probes to the HNC Deployment using functionality recently added to controller-runtime. The probes configuration might need some adjustments of timeouts etc. to work without issues for a typical HNC deployment. The default configuration should probably be adjusted; timeouts etc., and should be tested in a live cluster - which I do not have available.

Testing: Ran all tests successfully on my local workstation, when using the simple ping probe. But when changing to the deeper webhook probe, the container never becomes ready. Seems to be an issue related to cert-rotator - which I do not know at all. We use cert-manager. On request, Adrian Ludwin took a look at my issues, and somehow this seems to work for him.
    @erikgb
    erikgb committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    db2831b View commit details
    Browse the repository at this point in the history