Replace unstructured query with structured query #154
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/cc @adrianludwin |
|
/retest |
|
Since we are delaying #153 to 1.1, should this wait as well? |
No, this is an improvement/bugfix, and should go in. I have no idea why Unstructured was used for a CR defined in HNC. |
|
Agreed, I believe this is very safe.
…On Wed, Mar 23, 2022 at 7:09 PM Erik Godding Boye ***@***.***> wrote:
Since we are delaying #153
<#153> to
1.1, should this wait as well?
No, this is of an improvement/bugfix, and should go in. I have no idea why
Unstructured was used for a CRD defined in HNC.
—
Reply to this email directly, view it on GitHub
<#154 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE43PZBJON2HMOKTG5PV7ALVBOQDHANCNFSM5Q5JIZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Let's hold this until #160 goes in and we get a clean postsubmit run. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
Converted query for list of SubnamespaceAnchors to a structured query (no need to use UnstructuredList, and also had the list-kind bug described in the following).
Also fixing a bug in query for generic objects using UnstructuredList; when querying a List, one should use the object list kind (and not the object kind).
Tested: Ran unit-tests ('make test') and e2e-test ('make test-e2e') successfully.
erikgb
force-pushed
the
fix/unstructured-queries
branch
from
09b63da
to
9ddf800
Compare
|
Rebased and tested on my workstation now. Should be GTM. |
|
Postsubmits are clean again. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Converted query for list of SubnamespaceAnchors to a structured query (no need to use UnstructuredList, and also had the list-kind bug described in the following).
Also fixing a bug in query for generic objects using UnstructuredList; when querying a List, one should use the object list kind (and not the object kind).
Tested: Ran unit-tests ('make test') and e2e-test ('make test-e2e') successfully.
After the controller probes PR got merged, I am sadly no longer able to run integration test ('make test-e2e'). The pod is just crash looping. :-(Extracted from #153.