EXPERIMENTAL HA support #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
do-not-merge/hold
rjbez17
reviewed
Mar 25, 2022
adrianludwin
force-pushed
the
webhook-only
branch
from
5b233ec
to
154cb37
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This change lets the HNC manager be run both without webhooks and in webhook-only mode. This allows us to create two Deployments - one for the controller which actually makes changes, and another replicated deployment for the webhooks, each of which independently sync their in-memory forests and serve webhook requests. Taking advantage of this new feature requires considerable changes to the manifests, which I'm checking in as a separate commit. Tested: change passes smoke test when deployed with HA manifests, but I haven't done any careful validation that (for example) the HA deployment isn't actually writing anything.
adrianludwin
force-pushed
the
webhook-only
branch
from
154cb37
to
4e63495
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Erik's busy so submitting this now. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
erikgb
reviewed
Mar 28, 2022
| @@ -102,7 +102,7 @@ func HNCBeforeSuite() { | |||
| Expect(err).ToNot(HaveOccurred()) | |||
|
|
|||
| By("creating reconcilers") | |||
| err = setup.CreateReconcilers(k8sManager, forest.NewForest(), 100, true) | |||
| err = setup.CreateReconcilers(k8sManager, forest.NewForest(), 100, false, true) | |||
There was a problem hiding this comment.
Could it make sense to create some constants to make the code more readable? What does false, true really mean here? ReadOnlyMode, UseFakeClient would read better IMO.
There was a problem hiding this comment.
Whoops, I just removed the hold. This is an easy followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets the HNC manager be run both without webhooks and
in webhook-only mode. This allows us to create two Deployments - one for
the controller which actually makes changes, and another replicated
deployment for the webhooks, each of which independently sync their
in-memory forests and serve webhook requests.
Taking advantage of this new feature requires considerable changes to
the manifests, which I'm checking in as a separate commit.
Tested: change passes smoke test when deployed with HA manifests, but I
haven't done any careful validation that (for example) the HA deployment
isn't actually writing anything.