Introduce manifest variants #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
To see the output of this process, see |
erikgb
reviewed
Mar 28, 2022
erikgb
reviewed
Mar 28, 2022
This change updates the config and Makefile to produce multiple variants of the HNC manifests. The initial list is "default" (same as today), "default-cm" (same, but configured for cert-manager instead of the internal cert-controller), and ha (replicated webhooks, using the internal cert controller). Also made some updates to the Prow tests to allow for variant testing, as well as upgrading the ability to test the Prow tests locally. Tested: verified that default.yaml is the same as the prior hnc-manager.yaml, apart from some reordered command line args. Verified that smoke tests work on ha.yaml. Did not do _any_ testing on the cert-manager variants. Locally ran the prow e2e tests on both the HA and default configs. Also did an experimental release from my personal repo and bumped up the timeout since we've added more build targets.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the config and Makefile to produce multiple variants
of the HNC manifests. The initial list is "default" (same as today),
"default-cm" (same, but configured for cert-manager instead of the
internal cert-controller), and ha (replicated webhooks, using the
internal cert controller).
Also made some updates to the Prow tests to allow for variant testing,
as well as upgrading the ability to test the Prow tests locally.
Tested: verified that default.yaml is the same as the prior
hnc-manager.yaml, apart from some reordered command line args. Verified
that smoke tests work on ha.yaml. Did not do any testing on the
cert-manager variants. Locally ran the prow e2e tests on both the HA and
default configs. Also did an experimental release from my personal repo
and bumped up the timeout since we've added more build targets.
Fixes #151