-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhances cli create cmd to create subns with labels and ann #356
feat: enhances cli create cmd to create subns with labels and ann #356
Conversation
Hi @manjinder-mckc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manjinder-mckc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Although, I am having second thoughts about keeping the test case since it requires managed labels and annotations to be set in the test environment, not sure if that will be inconvenient to others testing, or if make deploy should handle it (but overkill?) .. open to thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, just one nit.
/ok-to-test
@@ -1,6 +1,7 @@ | |||
package e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind updating some of the existing tests that do not leverage this feature to ensure the label/annotations are NOT created?
@manjinder-mckc did you still plan on working on this? |
@rjbez17 yes, i just got caught up with other stuff and couldn't get it to it. But I will update the tests as soon as I can and have it ready |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No rush at all, appreciate you taking the time to help out!On Mar 8, 2024, at 10:14 PM, Manjinder ***@***.***> wrote:
@manjinder-mckc did you still plan on working on this?
@rjbez17 yes, i just got caught up with other stuff and couldn't get it to it. But I will update the tests as soon as I can and have it ready
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes Issue: #305
Tested: Tested by hand in local test cluster; added test and validated it works with and without annotation,label flags.