-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude openshift namespaces via regex #382
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zfrhv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @zfrhv. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mochizuki875 can you please tell if you like it? |
Thank you for your suggestion and PR! There is just one thing to note. Then, all files in So in this case, it's good to update |
bfc1c00
to
2a95760
Compare
22601d9
to
8815241
Compare
8815241
to
d04cc02
Compare
@mochizuki875 let me know if you want me to include the |
@zfrhv Ideally, |
in values.yaml the image repository seems to be broken |
Have you set some environment values? (see here) By setting these values as below, $ export HNC_REGISTRY=gcr.io/k8s-staging-multitenancy
$ export HNC_IMG_NAME=hnc-manager
$ export HNC_IMG_TAG=v1.1.0 values.yaml should be generated like this as a result of image:
repository: gcr.io/k8s-staging-multitenancy/hnc-manager
tag: v1.1.0
imagePullPolicy: {}
... |
4aa86ce
to
2ca63f0
Compare
Signed-off-by: Zakhar Pecherichny <zfrhv2010@gmail.com>
Signed-off-by: Zakhar Pecherichny <zfrhv2010@gmail.com>
2ca63f0
to
af675aa
Compare
sorry for making you feed me with a spoon |
/ok-to-test |
@zfrhv Related this PR, I have two questions.
|
|
@zfrhv Thanks your information;) |
Adding
--included-namespace-regex
option to the helm chart.as mentioned in the docs there is only
--included-namespace-regex
or--excluded-namespace
.so in order to exclude all
openshift.*
namespaces I used the--included-namespace-regex
as mentioned in this issue, this is added as an example invalues.yaml