Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to add included-namespace label and deprecate excluded label #40

Merged
merged 1 commit into from
May 20, 2021

Conversation

yiqigao217
Copy link
Contributor

@yiqigao217 yiqigao217 commented May 18, 2021

Part of #9.

Add included-namespace label to the HNC concepts page and mark
excluded-namespace label as deprecated in HNC v0.9 and later.

Update how-to page with new instructions on installing HNC and excluding
namespaces in HNC.

See previews:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2021
@k8s-ci-robot k8s-ci-robot requested a review from srampal May 18, 2021 22:07
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 18, 2021
@yiqigao217
Copy link
Contributor Author

/assign @adrianludwin
/assign @rjbez17

@yiqigao217 yiqigao217 removed the request for review from srampal May 18, 2021 22:08
docs/user-guide/concepts.md Outdated Show resolved Hide resolved
docs/user-guide/concepts.md Outdated Show resolved Hide resolved
docs/user-guide/how-to.md Outdated Show resolved Hide resolved
docs/user-guide/how-to.md Outdated Show resolved Hide resolved
Part of 9.

Add `included-namespace` label to the HNC concepts page and mark
`excluded-namespace` label as deprecated in HNC v0.9 and later.

Update how-to page with new instructions on installing HNC and excluding
namespaces in HNC.
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, yiqigao217

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit d41304d into kubernetes-sigs:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants