-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pod Annotations and Labels to Helm Chart #400
base: master
Are you sure you want to change the base?
Add Pod Annotations and Labels to Helm Chart #400
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @sanderv32! |
Hi @sanderv32. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanderv32 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR introduces support for adding custom annotations and labels to Pods created by the Helm chart. This enhancement provides better flexibility and allows for improved integration with external systems and workflows that rely on annotations or labels.
Changes:
• Added support for specifying Pod annotations in the
values.yaml
file.• Added support for specifying Pod labels in the
values.yaml
file.• Updated the
templates/hnc-controller-manager-ha.yaml
andtemplates/hnc-controller-manager.yaml
files to include the provided annotations and labels.• Verified changes to ensure backward compatibility when no annotations or labels are specified.
Why this change is necessary:
This change enhances the Helm chart’s configurability, enabling users to:
• Integrate with monitoring or logging tools that depend on specific annotations.
• Apply workload-specific metadata using labels for easier management and organization.