Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flag to disable stackdriver #77

Merged
merged 1 commit into from
Aug 27, 2021
Merged

add flag to disable stackdriver #77

merged 1 commit into from
Aug 27, 2021

Conversation

seankhliao
Copy link
Contributor

@seankhliao seankhliao commented Aug 27, 2021 •
edited
Loading

The stackdriver exporter logs permissions errors if it can find GCP credentials but has insufficient permissions to write metrics

Fixes #76

@k8s-ci-robot
Copy link
Contributor

Welcome @seankhliao!

It looks like this is your first PR to kubernetes-sigs/hierarchical-namespaces 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hierarchical-namespaces has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @seankhliao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 27, 2021
adrianludwin
adrianludwin reviewed Aug 27, 2021
View reviewed changes
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor code changes, otherwise lgtm.

Can you please:

  • Squash any changes into the same commit? We like only having one commit in the history (I really need to figure out how to do that automatically)
  • Add a note to the commit message stating what you tested? E.g. something like:
Tested: Installed without changing flags, and continued to see the error messages as expected. Added 
--export-to-stackdriver=false and the errors went away as expected.

cmd/manager/main.go Outdated
@@ -82,6 +83,7 @@ func init() {
func main() {
setupLog.Info("Parsing flags")
flag.StringVar(&metricsAddr, "metrics-addr", ":8080", "The address the metric endpoint binds to.")
flag.BoolVar(&metricsStackdriver, "metrics-stackdriver", true, "If true, export metrics to stackdriver")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe --enable-stackdriver or --export-metrics-stackdriver for consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to --enable-stackdriver

cmd/manager/main.go Show resolved Hide resolved
@seankhliao
add flag to disable stackdriver
ec42ee9 
Tested: Replaced existing installation of hnc v0.8.0 and continued to
see errors. Added --enable-stackdriver=false and didn't observe any
errors.
@seankhliao seankhliao force-pushed the metrics-stackdriver branch from 0d35f7e to ec42ee9 Compare August 27, 2021 19:51
adrianludwin
adrianludwin reviewed Aug 27, 2021
View reviewed changes
Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/cc @rjbez17 fyi

@k8s-ci-robot
Copy link
Contributor

@adrianludwin: GitHub didn't allow me to request PR reviews from the following users: fyi.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm
/approve
/cc @rjbez17 fyi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, seankhliao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2021
@adrianludwin
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2021
@seankhliao
Copy link
Contributor Author

At $work in the github repo merge settings we only turn on "Allow squash merging" which results in single commits / linear history. (We also turn on "Automatically delete head branches" to clean up branches and use branch protection rules to ensure these it's always done via squash merge)

@adrianludwin
Copy link
Contributor

adrianludwin commented Aug 27, 2021 via email

@k8s-ci-robot k8s-ci-robot merged commit b03328e into kubernetes-sigs:master Aug 27, 2021
@seankhliao seankhliao deleted the metrics-stackdriver branch August 27, 2021 20:19
@adrianludwin adrianludwin added this to the release-v0.9 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianludwin adrianludwin adrianludwin left review comments

@rjbez17 rjbez17 Awaiting requested review from rjbez17

@srampal srampal Awaiting requested review from srampal

Assignees

@adrianludwin adrianludwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
release-v0.9
Development

Successfully merging this pull request may close these issues.

Failed to export to Stackdriver code = PermissionDenied
3 participants
@seankhliao @k8s-ci-robot @adrianludwin