-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use controller-runtime 0.10.1 and Go 16 #84
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is currently blocked by kubernetes/test-infra#23754. |
/lgtm |
/retest |
Also updates controller-tools to v0.7.0, which required some changes to the makefile since some options have been removed. Tested: unit and smoke tests
@rjbez17 looks like we're good to go if you are |
/lgtm |
/hold cancel
…On Sat, 25 Sept 2021, 10:22 pm Ryan Bezdicek, ***@***.***> wrote:
/lgtm
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE43PZGI6CL23LGY4NIUND3UDZ7VBANCNFSM5EYF5E5A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Also updates controller-tools to v0.7.0, which required some changes to
the makefile since some options have been removed.
Tested: unit and smoke tests