Restructure by feature #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
adrianludwin
force-pushed
the
reorg
branch
3 times, most recently
from
e9f97ce
to
66710e4
Compare
k8s-ci-robot
added
the
do-not-merge/work-in-progress
HNC has always been divided into three main packages (all inside internal/): reconcilers, validators and mutators. This meant that any one feature (like subnamespace anchors) were split across multiple packages, with their internals exposed to other packages. It also ensured that all tests ran serially. This change refactors those three packages into five major ones (anchor, namespace, hierarchyconfig, hncconfig, and objects), as well as a few minor ones to cover code that's now shared across them (such as integtest). Tested: all integ and smoke tests pass.
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @rjbez17 Ryan, wdyt of this? |
|
Look at it earlier and was just waiting for you to fix the tests. I think it's a good idea. Thanks for taking this on! /lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HNC has always been divided into three main packages (all inside
internal/): reconcilers, validators and mutators. This meant that any
one feature (like subnamespace anchors) were split across multiple
packages, with their internals exposed to other packages. It also
ensured that all tests ran serially.
This change refactors those three packages into five major ones
(anchor, namespace, hierarchyconfig, hncconfig, and objects), as well as
a few minor ones to cover code that's now shared across them (such as
integtest).
Tested: all integ and smoke tests pass.