Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was missing O_TRUNC.
Without it, my first hydrophone run randomly had issues and was dumping a 142MB junit_01.xml, containing lots of pod logs. I then re-ran hydrophone on another cluster where the tests succeeded, but I still seemingly got a 142MB file.
In reality, hydrophone was fetching a 2.5MB file and was only updating/replacing the first 2.5MB of my junit_01.xml file, instead of overwriting it completely.
Adding O_TRUNC would make this more or less equivalent to OpenFile(), except that Create() sets file permissions to 0666 instead of our 0600, which I think is perfectly acceptable. The junit/e2e logs are not secret data that should be kept from other users on the system.